Re: [QuantLib-svn] SF.net SVN: quantlib: [10331] trunk/QuantLib

[Luigi Ballabio]

On Mon, 2007-04-23 at 06:29 -0700, [hidden email] wrote:
> Revision: 10331
>           http://quantlib.svn.sourceforge.net/quantlib/?rev=10331&view=rev
> Author:   nando
> Date:     2007-04-23 06:29:10 -0700 (Mon, 23 Apr 2007)
>
> Log Message:
> -----------
> renamed files in accordance with their current actual content

Is there any reason why on the one hand the header
marketmodelconstrainedevolver.hpp became constrainedevolver.hpp while on
the other hand exercisevalue.hpp became marketmodelexercisevalue.hpp?

Were we to choose, I'd go for the short format since the files are
contained in the marketmodel directory anyway. I wouldn't worry that the
class name doesn't match exactly the file name---and after all, it does
match if we take the parent folder into account.

Later,
        Luigi


----------------------------------------

Just remember what ol' Jack Burton does when the earth quakes, the
poison arrows fall from the sky, and the pillars of Heaven shake. Yeah,
Jack Burton just looks that big old storm right in the eye and says,
"Give me your best shot. I can take it."
-- Jack Burton, "Big trouble in Little China"



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev

[Ferdinando M. Ametrano-3]

On 4/23/07, Luigi Ballabio <[hidden email]> wrote:
> Is there any reason why on the one hand the header
> marketmodelconstrainedevolver.hpp became constrainedevolver.hpp while on
> the other hand exercisevalue.hpp became marketmodelexercisevalue.hpp?
The classes were named ConstrainedEvolver and MarketModelExerciseValue
respectively, so I just renamed the files from the classes, to fix the
confusion. I agree that MarketModelExerciseValue could be renamed just
ExerciseValue...

> Were we to choose, I'd go for the short format since the files are
> contained in the marketmodel directory anyway. I wouldn't worry that the
> class name doesn't match exactly the file name---and after all, it does
> match if we take the parent folder into account.
I prefer whenever possible the file name to match the class name. Any
alternative can easily have some ambiguity, e.g. for classes as
ParametricExercise (in the montecarlo folder) and
MarketModelParametricExercise (in the marketmodel folder)

ciao -- Nando

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev

[Luigi Ballabio]

On Tue, 2007-04-24 at 10:05 +0200, Ferdinando Ametrano wrote:
> > Were we to choose, I'd go for the short format since the files are
> > contained in the marketmodel directory anyway. I wouldn't worry that the
> > class name doesn't match exactly the file name---and after all, it does
> > match if we take the parent folder into account.
> I prefer whenever possible the file name to match the class name. Any
> alternative can easily have some ambiguity, e.g. for classes as
> ParametricExercise (in the montecarlo folder) and
> MarketModelParametricExercise (in the marketmodel folder)

Nando,
        true, but my point was that marketmodel/parametricexercise.hpp does
match MarketModelParametricExercise. Since we use the full path in
header inclusions, marketmodel/marketmodelparametricexercise.hpp is
redundant.

Later,
        Luigi


----------------------------------------

It is better to know some of the questions than all of the answers.
-- James Thurber



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev