Re: inflation seasonality added to trunk

Posted by Luigi Ballabio on
URL: http://quantlib.414.s1.nabble.com/inflation-seasonality-added-to-trunk-tp12855p12856.html

On Sun, 2009-06-28 at 07:44 -0700, Chris Kenyon wrote:

> I’ve added in seasonality to the inflation termstructures (thanks to
> Piero Del Boca and myself)

Chris,
        thanks. From a cursory glance, it seems ok. Just two things:

1) setSeasonality changes the rates returned by the curve methods, so it
should notify observers of the curve that something has changed;
2) I don't think you need a separate boolean hasSeasonalityCorrection_,
since you can write hasSeasonality() just as
    return seasonality_;
(shared pointers are converted to booleans like ordinary pointers.)

I can make the changes if you agree with them.

Later,
        Luigi


--

A debugged program is one for which you have not yet found the
conditions that make it fail.
-- Jerry Ogdin



------------------------------------------------------------------------------
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev