Re: Interest in fixing MSVC Level 4 warnings

Posted by Michael Sharpe on Jan 15, 2013; 5:20am
URL: http://quantlib.414.s1.nabble.com/Interest-in-fixing-MSVC-Level-4-warnings-tp13868p13916.html

Hi Luigi,

Thanks for your reply.

A quick upper bound on the amount of warnings that would need to be fixed is 1800. This is high because VS reports the same warning multiple times if the code in question is in headers, and also because boost has some level 4 warnings in uBLAS headers.

I'm more than willing to use my spare time to generate patches that would fix all the warnings, especially if they appear in headers so people who include quantlib headers can do so without needing to resort to workarounds if they want to bump up the warning level. When I submit the patches, I'll describe which warning the patch fixes and we can go from there.

Look for patches over the next week or two.

Mike

On Thu, Jan 10, 2013 at 9:31 AM, Luigi Ballabio <[hidden email]> wrote:

Hi Mike,
    given that we won't be able to go entirely warning-free (due to
QL_FAIL etc.) I wouldn't want you to invest too much time on this.
But if you want to have a look at the warnings and check if there's
anything that should be fixed, by all means go ahead.  A count might
indeed be useful in order to assess if the thing is worth pursuing.

Later,
    Luigi

On Sun, Jan 6, 2013 at 11:35 PM, Mike Sharpe <[hidden email]> wrote:
> Hi all,
>
> First, I'd like to start off by saying thanks for your hard work on
> quantlib! This is my first post to a quantlib mailing list. I've recently
> developed an interest in mathematical finance and discovered quantlib over
> the holidays, which has only piqued my interest more.
>
> As I'm still new to the codebase and most of the techniques that are used in
> the code, I'd like to give back in some other way and one of the ways I can
> do that is by looking into fixing some of the level 4 warnings for the
> Microsoft compilers. Because the warnings could appear anywhere and I don't
> want to cause any difficulties for other work, I wanted to check here to see
> if there was any interest in seeing these warnings fixed.
>
> I'm not necessarily proposing fixing all of the warnings that I've seen in
> the code (QL_FAIL triggers C4127 "conditional expression is constant"
> because of the do { } while(false) macro guard, for example), but I do think
> it'd a good idea to look through the list and fix some of them. If a count
> of warnings would help, I can follow up with that soon.
>
> Mike
>
>

> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_123012
> _______________________________________________
> QuantLib-dev mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/quantlib-dev
>

------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev