Re: AW: Tokyo Holidays fixes

Posted by KAWANISHI Tomoya on
URL: http://quantlib.414.s1.nabble.com/Tokyo-Calendar-Equinox-patch-tp2359p2362.html

Hi.

On Tue, 28 Jan 2003 12:05:02 +0100
"Jens Thiel" <[hidden email]> wrote:

> Tomoya,
>
> was the first "Emperor's birthday" in 1988 (your description) or 1989 (your
> code)?
Code is correct.
First "Emperor's birthday" was in 1989.

And I found one mistake on holiday for a nation.
> || (w == Tuesday && d+1 == ae && m == September && y >= 2003)
This code should be
|| (w == Tuesday && d+1 == ae && d >= 16 && d <= 22 && m == September && y >= 2003)
There is a rule that a day between legal holidays is legal holiday.
Please make the CVS correct.

---
KAWANISHI Tomoya [hidden email]
KAWANISHI is surname.
Tomoya    is first name.

>
> Jens.
>
> > 23rd December is "Emperor's birthday" since 1988.
> [...]
> >
> >  // Emperor's Birthday
> >  || ((d == 23 || (d == 24 && w == Monday)) && m == December && y >= 1989)