Login  Register

Re: Why the scope of WesternImpl::isWeekend is changed from public from protected?

Posted by Luigi Ballabio on Jul 16, 2012; 3:43pm
URL: http://quantlib.414.s1.nabble.com/Why-the-scope-of-WesternImpl-isWeekend-is-changed-from-public-from-protected-tp8737p8738.html

It might be a leftover from some changes that weren't well
synchronized.  In this case it doesn't hurt, but I'll change it back.

Luigi

On Tue, Jul 10, 2012 at 5:03 PM, Mike Jake <[hidden email]> wrote:

>     class Calendar {
>       protected:
>         //! abstract base class for calendar implementations
>         class Impl {
>           public:
>             virtual bool isWeekend(Weekday) const = 0;
>             ...
>         };
>
>         class WesternImpl : public Impl {
>           protected:
>             bool isWeekend(Weekday) const;
>             ...
>         };
>
> If I were right, changing the virtual function scope is NOT a good
> practice in c++. So why we decide to do so here?
>
> Thank you
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> QuantLib-users mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/quantlib-users

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
QuantLib-users mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-users