unreferenced formal parameter in Line-search based optimization method

[Ferdinando M. Ametrano-3]

Hi all

the implementations in derived classes (ConjugateGradient, BFGS, SteepestDescent) of

LineSearchBasedMethod::getUpdatedDirection(Problem &P,
                                           Real fold,
                                           Real gold2,
                                           const Array& gradient) = 0;

never use the second parameter Real fold.

Is the parameter to be removed or it might be used by some future line-search based optimization method?

Nicolas, Frédéric? Anyone else?

ciao -- Nando

RSS feed: http://www.google.com/reader/shared/ferdinando.ametrano


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev

[Ferdinando M. Ametrano-3]

ok fixed declaring getUpdatedDirection as protected and removing the
unused parameter from its signature

http://quantlib.svn.sourceforge.net/viewvc/quantlib?view=rev&revision=16837

On Wed, Nov 25, 2009 at 7:37 PM, Ferdinando Ametrano <[hidden email]> wrote:

> Hi all
>
> the implementations in derived classes (ConjugateGradient, BFGS,
> SteepestDescent) of
>
> LineSearchBasedMethod::getUpdatedDirection(Problem &P,
>                                            Real fold,
>                                            Real gold2,
>                                            const Array& gradient) = 0;
>
> never use the second parameter Real fold.
>
> Is the parameter to be removed or it might be used by some future
> line-search based optimization method?
>
> Nicolas, Frédéric? Anyone else?
>
> ciao -- Nando
>
> RSS feed: http://www.google.com/reader/shared/ferdinando.ametrano
>
>

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
QuantLib-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/quantlib-dev